Skip to content

refactor(network): migrate net.IP to netip#255

Draft
LaurenceJJones wants to merge 458 commits into
fosrl:devfrom
LaurenceJJones:migrate-to-netip
Draft

refactor(network): migrate net.IP to netip#255
LaurenceJJones wants to merge 458 commits into
fosrl:devfrom
LaurenceJJones:migrate-to-netip

Conversation

@LaurenceJJones

@LaurenceJJones LaurenceJJones commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Simply migrate from net.ip to netip golang package which has improved code and access methods

How to test?

simply internal only changes.

miloschwartz and others added 30 commits September 29, 2025 16:38
@miloschwartz
update template
71c5bf7
@oschwartz10612
Try to fix overwriting config file
348b8f6
@dependabot
Bump the prod-minor-updates group across 1 directory with 2 updates
f287888 
Bumps the prod-minor-updates group with 2 updates in the / directory: [github.com/docker/docker](https://github.com/docker/docker) and [golang.org/x/net](https://github.com/golang/net).


Updates `github.com/docker/docker` from 28.4.0+incompatible to 28.5.0+incompatible
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v28.4.0...v28.5.0)

Updates `golang.org/x/net` from 0.44.0 to 0.45.0
- [Commits](golang/net@v0.44.0...v0.45.0)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-version: 28.5.0+incompatible
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: golang.org/x/net
  dependency-version: 0.45.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
...

Signed-off-by: dependabot[bot] <support@github.com>
@oschwartz10612
Merge pull request fosrl#156 from fosrl/dependabot/go_modules/prod-mi…
fb110ba 
…nor-updates-51461da29c

Bump the prod-minor-updates group across 1 directory with 2 updates
@oschwartz10612
Merge pull request fosrl#157 from fosrl/dev
b383cec 
No cloud, config file overwriting, hp
@dependabot
Bump github.com/docker/docker in the prod-patch-updates group
552617c 
Bumps the prod-patch-updates group with 1 update: [github.com/docker/docker](https://github.com/docker/docker).


Updates `github.com/docker/docker` from 28.5.0+incompatible to 28.5.1+incompatible
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v28.5.0...v28.5.1)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-version: 28.5.1+incompatible
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: prod-patch-updates
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump the prod-minor-updates group with 2 updates
c729ab5 
Bumps the prod-minor-updates group with 2 updates: [golang.org/x/crypto](https://github.com/golang/crypto) and [golang.org/x/net](https://github.com/golang/net).


Updates `golang.org/x/crypto` from 0.42.0 to 0.43.0
- [Commits](golang/crypto@v0.42.0...v0.43.0)

Updates `golang.org/x/net` from 0.45.0 to 0.46.0
- [Commits](golang/net@v0.45.0...v0.46.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.43.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: golang.org/x/net
  dependency-version: 0.46.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
...

Signed-off-by: dependabot[bot] <support@github.com>
@marcschaeferger
Adding OpenTelemetry Metrics and Tracing
c086e69
@oschwartz10612
Merge pull request fosrl#159 from fosrl/dependabot/go_modules/prod-mi…
9fec22a 
…nor-updates-a55d2abe4a

Bump the prod-minor-updates group with 2 updates
@oschwartz10612
Merge pull request fosrl#158 from fosrl/dependabot/go_modules/prod-pa…
6048f24 
…tch-updates-46361b25de

Bump github.com/docker/docker from 28.5.0+incompatible to 28.5.1+incompatible in the prod-patch-updates group
@marcschaeferger
Remove Coolify Code
6d2073a
@oschwartz10612
Update runner
7f8ee37
@oschwartz10612
Add documentation for cli and reporg
bda1d04
@oschwartz10612
Add log message that the server is on
d63d8d6
@oschwartz10612
Merge pull request fosrl#162 from marcschaeferger/otel
7a07437 
Adding OpenTelemetry Metrics and Tracing
@oschwartz10612
Merge branch 'main' of github.com:fosrl/newt
6b1c1ed
@oschwartz10612
Merge branch 'dev' of github.com:fosrl/newt into dev
7c780f7
@oschwartz10612
Update domain
ddc3765
@marcschaeferger
feat(actions): Sync Images from Docker to GHCR
a729b91
@oschwartz10612
Merge pull request fosrl#165 from marcschaeferger/ghcr
915e7e4 
feat(actions): Sync Images from Docker to GHCR
@marcschaeferger
ci(actions): pin action versions to commit SHAs for security
ec05686 
- Pin actions/checkout to SHA for v5.0.0
- Pin docker/setup-qemu-action to SHA for v3.6.0
- Pin docker/setup-buildx-action to SHA for v3.11.1
- Pin docker/login-action to SHA for v3.6.0
- Pin actions/setup-go to SHA for v6.0.0
- Pin actions/upload-artifact to SHA for v4.6.2
@marcschaeferger
ci(actions): add GHCR mirroring and cosign signing for Docker images
2a273dc 
- mirror images from Docker Hub to GHCR using skopeo (preserves multi-arch manifests)
- login to GHCR via docker/login-action for signing/pushing
- install cosign and perform dual signing: keyless (OIDC) + key-based; verify signatures
- add required permissions for id-token/packages and reference necessary secrets
@marcschaeferger
ci(actions): change runner from ubuntu-latest to amd64-runner for CI/…
a1a3d63 
…CD workflows
@oschwartz10612
Merge pull request fosrl#166 from marcschaeferger/gh-action
f1e0727 
Adding GHCR to CI/CD Release Workflow & further improvements
@oschwartz10612
Add doc for SKIP_TLS_VERIFY
ed99dce
@oschwartz10612
Add doc for SKIP_TLS_VERIFY
8d3ae5a
@oschwartz10612
Merge branch 'main' into dev
ff07692
@oschwartz10612
Update cicd
527321a
@marcschaeferger
Added Improvements for CICD Action
ee3e7d1
@marcschaeferger
testdata: add expected telemetry metrics for connection attempts and …
7d60240 
…events
LaurenceJJones and others added 29 commits February 22, 2026 14:22
@LaurenceJJones
fix: address code review issues for BART subnet lookup
9738565 
- Fix prefix canonicalization: use Masked() to handle host bits correctly
  (e.g., 10.0.0.5/24 and 10.0.0.0/24 are now treated as equal)
- Fix empty trie cleanup: use BART's Size() method to check if trie is empty
  instead of relying on rules slice length, preventing stale entries
- Fix go.mod: move BART from indirect to direct dependencies

These fixes ensure proper bookkeeping and prevent memory leaks from
empty tries hanging around after rule removal.
@oschwartz10612
Merge branch 'main' into dev
01e2ba3
@oschwartz10612
Merge pull request fosrl#242 from fosrl/dev
1a3eaed 
1.10.0
@oschwartz10612
Fix port parsing
514c945 
Fixes fosrl#243
@oschwartz10612
Update iss
555e1dd
@miloschwartz
generate random user password
1bf89a2
@oschwartz10612
Merge pull request fosrl#245 from fosrl/dev
1656141 
generate random user password
@oschwartz10612
Pull from ecr
b2600b0
@dependabot
chore(deps): bump go.opentelemetry.io/otel/sdk from 1.39.0 to 1.40.0
c5ae4a8 
Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.39.0 to 1.40.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/sdk
  dependency-version: 1.40.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(nix): fix hash for updated go dependencies
9b8bc7b
@marcschaeferger
Merge pull request fosrl#248 from fosrl/dependabot/go_modules/go.open…
23dc230 
…telemetry.io/otel/sdk-1.40.0

chore(deps): bump go.opentelemetry.io/otel/sdk from 1.39.0 to 1.40.0
@dependabot
chore(deps): bump the prod-minor-updates group across 1 directory wit…
6e79eef 
…h 13 updates

Bumps the prod-minor-updates group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib) | `0.64.0` | `0.65.0` |
| [go.opentelemetry.io/contrib/instrumentation/runtime](https://github.com/open-telemetry/opentelemetry-go-contrib) | `0.64.0` | `0.65.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc](https://github.com/open-telemetry/opentelemetry-go) | `1.39.0` | `1.40.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) | `1.39.0` | `1.40.0` |
| [go.opentelemetry.io/otel/exporters/prometheus](https://github.com/open-telemetry/opentelemetry-go) | `0.61.0` | `0.62.0` |



Updates `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` from 0.64.0 to 0.65.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.64.0...zpages/v0.65.0)

Updates `go.opentelemetry.io/contrib/instrumentation/runtime` from 0.64.0 to 0.65.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.64.0...zpages/v0.65.0)

Updates `go.opentelemetry.io/otel` from 1.39.0 to 1.40.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc` from 1.39.0 to 1.40.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` from 1.39.0 to 1.40.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0)

Updates `go.opentelemetry.io/otel/exporters/prometheus` from 0.61.0 to 0.62.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@exporters/prometheus/v0.61.0...exporters/prometheus/v0.62.0)

Updates `go.opentelemetry.io/otel/metric` from 1.39.0 to 1.40.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0)

Updates `go.opentelemetry.io/otel/sdk` from 1.39.0 to 1.40.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0)

Updates `go.opentelemetry.io/otel/sdk/metric` from 1.39.0 to 1.40.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0)

Updates `golang.org/x/crypto` from 0.46.0 to 0.47.0
- [Commits](golang/crypto@v0.46.0...v0.47.0)

Updates `golang.org/x/net` from 0.48.0 to 0.49.0
- [Commits](golang/net@v0.48.0...v0.49.0)

Updates `golang.org/x/sys` from 0.39.0 to 0.40.0
- [Commits](golang/sys@v0.39.0...v0.40.0)

Updates `google.golang.org/grpc` from 1.77.0 to 1.78.0
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.77.0...v1.78.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
  dependency-version: 0.65.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/contrib/instrumentation/runtime
  dependency-version: 0.65.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/otel
  dependency-version: 1.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc
  dependency-version: 1.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
  dependency-version: 1.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/otel/exporters/prometheus
  dependency-version: 0.62.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/otel/metric
  dependency-version: 1.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/otel/sdk
  dependency-version: 1.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/otel/sdk/metric
  dependency-version: 1.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: golang.org/x/crypto
  dependency-version: 0.47.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: golang.org/x/net
  dependency-version: 0.49.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: golang.org/x/sys
  dependency-version: 0.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: google.golang.org/grpc
  dependency-version: 1.78.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(nix): fix hash for updated go dependencies
06e175a
@marcschaeferger
Merge pull request fosrl#235 from fosrl/dependabot/github_actions/doc…
4bcd2ff 
…ker/build-push-action-6.19.2

chore(deps): bump docker/build-push-action from 6.18.0 to 6.19.2
@marcschaeferger
Merge pull request fosrl#232 from fosrl/dependabot/github_actions/doc…
de3d358 
…ker/login-action-3.7.0

chore(deps): bump docker/login-action from 3.6.0 to 3.7.0
@marcschaeferger
Merge pull request fosrl#231 from fosrl/dependabot/github_actions/act…
d6ea37f 
…ions/attest-build-provenance-3.2.0

chore(deps): bump actions/attest-build-provenance from 3.1.0 to 3.2.0
@marcschaeferger
Merge pull request fosrl#230 from fosrl/dependabot/github_actions/act…
6d5e099 
…ions/cache-5.0.3

chore(deps): bump actions/cache from 5.0.1 to 5.0.3
@marcschaeferger
Merge pull request fosrl#227 from fosrl/dependabot/github_actions/act…
19f143f 
…ions/setup-go-6.2.0

chore(deps): bump actions/setup-go from 6.1.0 to 6.2.0
@oschwartz10612
Merge pull request fosrl#204 from LaurenceJJones/optimize-subnet-look…
ec399e9 
…up-bart

perf(netstack2): optimize subnet rule matching with BART
@oschwartz10612
Merge branch 'optimize-reverse-nat-lookup' of github.com:LaurenceJJon…
3f84354 
…es/newt into LaurenceJJones-optimize-reverse-nat-lookup
@oschwartz10612
Merge branch 'LaurenceJJones-optimize-reverse-nat-lookup' into dev
6c6ba45
@oschwartz10612
Merge pull request fosrl#233 from fosrl/dependabot/go_modules/prod-mi…
30ade81 
…nor-updates-85791fb009

chore(deps): bump the prod-minor-updates group across 1 directory with 13 updates
@dependabot
chore(deps): bump the prod-minor-updates group with 3 updates
1c22555 
Bumps the prod-minor-updates group with 3 updates: [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib), [go.opentelemetry.io/contrib/instrumentation/runtime](https://github.com/open-telemetry/opentelemetry-go-contrib) and [golang.org/x/net](https://github.com/golang/net).


Updates `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` from 0.65.0 to 0.66.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.65.0...zpages/v0.66.0)

Updates `go.opentelemetry.io/contrib/instrumentation/runtime` from 0.65.0 to 0.66.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.65.0...zpages/v0.66.0)

Updates `golang.org/x/net` from 0.50.0 to 0.51.0
- [Commits](golang/net@v0.50.0...v0.51.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
  dependency-version: 0.66.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: go.opentelemetry.io/contrib/instrumentation/runtime
  dependency-version: 0.66.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
- dependency-name: golang.org/x/net
  dependency-version: 0.51.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-minor-updates
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(nix): fix hash for updated go dependencies
86a7d79
@oschwartz10612
Merge pull request fosrl#249 from fosrl/dependabot/go_modules/prod-mi…
bf7882e 
…nor-updates-26e8ddd78e

chore(deps): bump the prod-minor-updates group with 3 updates
@oschwartz10612
Fix --port
7920295
@oschwartz10612
Fix icmp when ports disabled
e474866 
Fixes fosrl#247
@oschwartz10612
Merge pull request fosrl#250 from fosrl/dev
beaf386 
1.10.2
@LaurenceJJones
refactor(network): migrate net.IP to netip across interface/route/hol…
4f23dc3 
…epunch/netstack paths with safer AddrFromSlice validation

  and UDP AddrPort conversions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oschwartz10612 oschwartz10612 Awaiting requested review from oschwartz10612 oschwartz10612 will be requested when the pull request is marked ready for review oschwartz10612 is a code owner

@miloschwartz miloschwartz Awaiting requested review from miloschwartz miloschwartz will be requested when the pull request is marked ready for review miloschwartz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LaurenceJJones @miloschwartz @oschwartz10612 @marcschaeferger @water-sucks